Change in openvpn[master]: DNS server documentation update
A message that is not in the archive (sent off-list or not yet received): gerrit.1777558352000.I53b3f4c60897a1f4dd5efeb6575d525ffb082402@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email
to review the following change.
Change subject: DNS server documentation update
......................................................................
DNS server documentation update
---
M doc/man-sections/client-options.rst
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/46/1646/1
doc/man-sections/client-options.rst +12 -1
@@ -216,7 +216,8 @@ DNS server options it must be between 0 and 127. The server id is used to group options and also for ordering the list of configured DNS servers; lower numbers come first. DNS servers being pushed to a client replace - already configured DNS servers with the same server id. + already configured DNS servers with the same server id. Only the group of + options corresponding to the lowest server id is applied. The ``address`` option configures the IPv4 and / or IPv6 address(es) of the DNS server. Up to eight addresses can be specified per DNS server.
@@ -249,6 +250,16 @@ so that ``--dns`` overrides ``--dhcp-option``. Thus, ``--dns`` can be used today to migrate from ``--dhcp-option``. + Windows only: (i) If tap-windows6 is in use, dns servers are set by DHCP by + default. In this case only ``--dns search-domains`` and ``--dns server n address ..`` + with the lowest value of ``n`` are interpreted. All other ``--dns`` options + are ignored. Use of the dco driver is the recommended way to make use of these + new features. + (ii) If ``--dns server n resolve-domains`` is in use, the DNS server addresses + corresponding to ``n`` are set on the interface only if ``search-domains`` is + also specified. Otherwise these DNS addresses are used only for NRPT rules for + split-DNS. + --explicit-exit-notify n In UDP client mode or point-to-point mode, send server/peer an exit notification if tunnel is restarted or OpenVPN process is exited. In
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53b3f4c60897a1f4dd5efeb6575d525ffb082402
Gerrit-Change-Number: 1646
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: plaisthos.
selvanair has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email )
Change subject: DNS server documentation update
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This was discussed in https://github.com/OpenVPN/openvpn/issues/937 but I forgot to submit it, it seems. Looks like its still relevant.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53b3f4c60897a1f4dd5efeb6575d525ffb082402
Gerrit-Change-Number: 1646
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Comment-Date: Thu, 30 Apr 2026 14:16:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: plaisthos, selvanair.
flichtenheld has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email )
Change subject: DNS server documentation update
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File doc/man-sections/client-options.rst:
http://gerrit.openvpn.net/c/openvpn/+/1646/comment/bec2e88f_3369753c?usp=email :
PS1, Line 253: Windows only: (i) If tap-windows6 is in use, dns servers are set by DHCP by
Please make it an actual list in rst.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53b3f4c60897a1f4dd5efeb6575d525ffb082402
Gerrit-Change-Number: 1646
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: selvanair <[email protected]...>
Gerrit-Comment-Date: Thu, 30 Apr 2026 15:11:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: flichtenheld, plaisthos.
selvanair has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email )
Change subject: DNS server documentation update
......................................................................
Patch Set 1:
(1 comment)
File doc/man-sections/client-options.rst:
http://gerrit.openvpn.net/c/openvpn/+/1646/comment/db05ca2a_9fca3206?usp=email :
PS1, Line 253: Windows only: (i) If tap-windows6 is in use, dns servers are set by DHCP by
Quoted 1 line
Please make it an actual list in rst.
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53b3f4c60897a1f4dd5efeb6575d525ffb082402
Gerrit-Change-Number: 1646
Gerrit-PatchSet: 1
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Thu, 30 Apr 2026 15:36:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]...>
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by flichtenheld
Change subject: DNS server documentation update
......................................................................
DNS server documentation update
---
M doc/man-sections/client-options.rst
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/46/1646/2
doc/man-sections/client-options.rst +15 -1
@@ -216,7 +216,8 @@ DNS server options it must be between 0 and 127. The server id is used to group options and also for ordering the list of configured DNS servers; lower numbers come first. DNS servers being pushed to a client replace - already configured DNS servers with the same server id. + already configured DNS servers with the same server id. Only the group of + options corresponding to the lowest server id is applied. The ``address`` option configures the IPv4 and / or IPv6 address(es) of the DNS server. Up to eight addresses can be specified per DNS server.
@@ -249,6 +250,19 @@ so that ``--dns`` overrides ``--dhcp-option``. Thus, ``--dns`` can be used today to migrate from ``--dhcp-option``. + Windows only: + + #. If tap-windows6 is in use, dns servers are set by DHCP by default. + In this case only ``--dns search-domains`` and ``--dns server n address ..`` + with the lowest value of ``n`` are interpreted. All other ``--dns`` options + are ignored. Use of the dco driver is the recommended way to make use of these + new features. + + #. If ``--dns server n resolve-domains`` is in use, the DNS server addresses + corresponding to ``n`` are set on the interface only if ``search-domains`` is + also specified. Otherwise these DNS addresses are used only for NRPT rules for + split-DNS. + --explicit-exit-notify n In UDP client mode or point-to-point mode, send server/peer an exit notification if tunnel is restarted or OpenVPN process is exited. In
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53b3f4c60897a1f4dd5efeb6575d525ffb082402
Gerrit-Change-Number: 1646
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Attention is currently required from: plaisthos, selvanair.
flichtenheld has posted comments on this change by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email )
Change subject: DNS server documentation update
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53b3f4c60897a1f4dd5efeb6575d525ffb082402
Gerrit-Change-Number: 1646
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: selvanair <[email protected]...>
Gerrit-Comment-Date: Thu, 30 Apr 2026 15:49:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
PATCH v2 1/1 DNS server documentation update
In reply to a message not in the archiveFrom: Selva Nair <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1646
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1646
This mail reflects revision 2 of this Change.
Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <[email protected]...>
doc/man-sections/client-options.rst +15 -1
@@ -216,7 +216,8 @@ DNS server options it must be between 0 and 127. The server id is used to group options and also for ordering the list of configured DNS servers; lower numbers come first. DNS servers being pushed to a client replace - already configured DNS servers with the same server id. + already configured DNS servers with the same server id. Only the group of + options corresponding to the lowest server id is applied. The ``address`` option configures the IPv4 and / or IPv6 address(es) of the DNS server. Up to eight addresses can be specified per DNS server.
@@ -249,6 +250,19 @@ so that ``--dns`` overrides ``--dhcp-option``. Thus, ``--dns`` can be used today to migrate from ``--dhcp-option``. + Windows only: + + #. If tap-windows6 is in use, dns servers are set by DHCP by default. + In this case only ``--dns search-domains`` and ``--dns server n address ..`` + with the lowest value of ``n`` are interpreted. All other ``--dns`` options + are ignored. Use of the dco driver is the recommended way to make use of these + new features. + + #. If ``--dns server n resolve-domains`` is in use, the DNS server addresses + corresponding to ``n`` are set on the interface only if ``search-domains`` is + also specified. Otherwise these DNS addresses are used only for NRPT rules for + split-DNS. + --explicit-exit-notify n In UDP client mode or point-to-point mode, send server/peer an exit notification if tunnel is restarted or OpenVPN process is exited. In
[Openvpn-devel] [PATCH applied] Re: DNS server documentation update
Thanks, this is a very welcome addition / clarification (and for whatever reason, it tends to get stuck somewhere).
Your patch has been applied to the master and release/2.7 branch (docs).
commit c77d3e90d9d97e5447d35b545f9c8f07bf4c8ce3 (master) commit f50d2e140beaca82dc6f842f8761606279e0218f (release/2.7)
Author: Selva Nair Date: Thu Apr 30 18:32:43 2026 +0200
DNS server documentation update
Signed-off-by: Selva Nair <[email protected]...>
Acked-by: Frank Lichtenheld <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1646
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36816.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#3) to the change originally created by selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: DNS server documentation update
......................................................................
DNS server documentation update
Github: OpenVPN/openvpn#937
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1646
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36816.html
---
M doc/man-sections/client-options.rst
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/46/1646/3
doc/man-sections/client-options.rst +15 -1
@@ -216,7 +216,8 @@ DNS server options it must be between 0 and 127. The server id is used to group options and also for ordering the list of configured DNS servers; lower numbers come first. DNS servers being pushed to a client replace - already configured DNS servers with the same server id. + already configured DNS servers with the same server id. Only the group of + options corresponding to the lowest server id is applied. The ``address`` option configures the IPv4 and / or IPv6 address(es) of the DNS server. Up to eight addresses can be specified per DNS server.
@@ -249,6 +250,19 @@ so that ``--dns`` overrides ``--dhcp-option``. Thus, ``--dns`` can be used today to migrate from ``--dhcp-option``. + Windows only: + + #. If tap-windows6 is in use, dns servers are set by DHCP by default. + In this case only ``--dns search-domains`` and ``--dns server n address ..`` + with the lowest value of ``n`` are interpreted. All other ``--dns`` options + are ignored. Use of the dco driver is the recommended way to make use of these + new features. + + #. If ``--dns server n resolve-domains`` is in use, the DNS server addresses + corresponding to ``n`` are set on the interface only if ``search-domains`` is + also specified. Otherwise these DNS addresses are used only for NRPT rules for + split-DNS. + --explicit-exit-notify n In UDP client mode or point-to-point mode, send server/peer an exit notification if tunnel is restarted or OpenVPN process is exited. In
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53b3f4c60897a1f4dd5efeb6575d525ffb082402
Gerrit-Change-Number: 1646
Gerrit-PatchSet: 3
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email )
Change subject: DNS server documentation update
......................................................................
DNS server documentation update
Github: OpenVPN/openvpn#937
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1646
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36816.html
---
M doc/man-sections/client-options.rst
1 file changed, 15 insertions(+), 1 deletion(-)
doc/man-sections/client-options.rst +15 -1
@@ -216,7 +216,8 @@ DNS server options it must be between 0 and 127. The server id is used to group options and also for ordering the list of configured DNS servers; lower numbers come first. DNS servers being pushed to a client replace - already configured DNS servers with the same server id. + already configured DNS servers with the same server id. Only the group of + options corresponding to the lowest server id is applied. The ``address`` option configures the IPv4 and / or IPv6 address(es) of the DNS server. Up to eight addresses can be specified per DNS server.
@@ -249,6 +250,19 @@ so that ``--dns`` overrides ``--dhcp-option``. Thus, ``--dns`` can be used today to migrate from ``--dhcp-option``. + Windows only: + + #. If tap-windows6 is in use, dns servers are set by DHCP by default. + In this case only ``--dns search-domains`` and ``--dns server n address ..`` + with the lowest value of ``n`` are interpreted. All other ``--dns`` options + are ignored. Use of the dco driver is the recommended way to make use of these + new features. + + #. If ``--dns server n resolve-domains`` is in use, the DNS server addresses + corresponding to ``n`` are set on the interface only if ``search-domains`` is + also specified. Otherwise these DNS addresses are used only for NRPT rules for + split-DNS. + --explicit-exit-notify n In UDP client mode or point-to-point mode, send server/peer an exit notification if tunnel is restarted or OpenVPN process is exited. In
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1646?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I53b3f4c60897a1f4dd5efeb6575d525ffb082402
Gerrit-Change-Number: 1646
Gerrit-PatchSet: 3
Gerrit-Owner: selvanair <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>